Skip to content

Gradle project is created with deprecated features (Project.getConvention)#1427

Closed
prithvitewatia wants to merge 3 commits intospring-io:mainfrom
prithvitewatia:gh-1420_gradle_writer
Closed

Gradle project is created with deprecated features (Project.getConvention)#1427
prithvitewatia wants to merge 3 commits intospring-io:mainfrom
prithvitewatia:gh-1420_gradle_writer

Conversation

@prithvitewatia
Copy link
Copy Markdown
Contributor

Closes #1423.

Updated gradle build writer to write java configuration instead of source compatibility

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 13, 2023
@prithvitewatia
Copy link
Copy Markdown
Contributor Author

@snicoll Please review this PR instead of the old one. I have made the requested changes. Thanks.

@snicoll snicoll changed the title Gh 1420. Java configuration added to gradle project Gradle project is created with deprecated features (Project.getConvention) Jun 13, 2023
@snicoll snicoll self-assigned this Jun 13, 2023
@snicoll snicoll added type: bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 13, 2023
@snicoll snicoll added this to the 0.20.0 milestone Jun 13, 2023
snicoll pushed a commit that referenced this pull request Jun 14, 2023
snicoll added a commit that referenced this pull request Jun 14, 2023
@snicoll snicoll closed this in 9f80fa7 Jun 14, 2023
@snicoll
Copy link
Copy Markdown
Contributor

snicoll commented Jun 14, 2023

Very nice, thanks again @prithvitewatia

@prithvitewatia
Copy link
Copy Markdown
Contributor Author

I am happy to help @snicoll 😄

@prithvitewatia prithvitewatia deleted the gh-1420_gradle_writer branch June 14, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants