build: bump up Gradle to v6 by KengoTODA · Pull Request #1061 · spotbugs/spotbugs

KengoTODA · 2020-01-16T02:57:58Z

configure Gradle wrapper to use Gradle v6.1
follow the official guideline to migrate from v5 to v6
- Replace java plugin with java-library that provides suggested api and implementation
- replace compile and testCompile configuration with api, implementation and testImplementation
- update configuration related to jacoco
upgrade spotless to support the latest Gradle

https://docs.gradle.org/current/userguide/java_library_plugin.html\#sec:java_library_separation

…ot run

This reverts commit 96ffe22.

KengoTODA · 2020-01-16T11:11:53Z

This change affects the <scope> of dependencies: jaxen and Saxon becomes runtime package.
I think it is OK because usage of them isn't exposed on any SpotBugs API.

  <dependency>
    <groupId>jaxen</groupId>
    <artifactId>jaxen</artifactId>
    <version>1.1.6</version>
    <scope>runtime</scope>
  </dependency>
  <dependency>
    <groupId>net.sf.saxon</groupId>
    <artifactId>Saxon-HE</artifactId>
    <version>9.9.1-2</version>
    <scope>runtime</scope>
  </dependency>

KengoTODA · 2020-01-16T12:32:48Z

the coverage info is not generated as expected, I will try to fix it.

sonarqubecloud · 2020-01-16T14:37:55Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

KengoTODA · 2020-01-16T14:42:40Z

Confirmed that jacocoRootReport works as expected in this build:

https://travis-ci.org/spotbugs/spotbugs/jobs/637976286?utm_medium=notification&utm_source=github_status

@spotbugs/everyone this PR is ready to review, please check.
The commit history is not beautiful, better to squash-and-merge. ;)

this feature was disabled by #1061 unexpectedly

* ci: build SpotBugs with Eclipse in PR * ci: run SonarQube analysis on the GitHub Actions * ci: ensure sonarqube task runs after jacocoRootReport task * ci: fetch all histories in the target branch to avoid the following error from :sonarqube task > Could not find ref: master in refs/heads, refs/remotes/upstream or refs/remotes/origin * ci: upgrade scanner-api to fix connection leak bug SonarSource/sonar-scanner-java-library@c0c757f * ci: add GITHUB_TOKEN to build, to use GitHub Checks in PR * ci: fix checkout config * ci: omit verbose log of wget to make the build log enough small * ci: upgrade scanner-api to fix connection leak bug * ci: enable build scan to confirm that the updated sonar-scanner-api is used https://guides.gradle.org/creating-build-scans/ * ci: try to bump up sonar-scanner-engine to the latest ver. * ci: try to git-fetch to avoid SQ error https://community.sonarsource.com/t/error-warn-could-not-find-ref-develop-in-refs-heads-or-refs-remotes-origin-after-updating-to-7-6/6420/3\?u\=kengotoda * build: add com.gradle.enterprise plugin to stabilize builds on Travis * ci: simplify SQ related build script * ci: remove build-scan related config to stabilize build on Travis CI * Revert "ci: remove build-scan related config to stabilize build on Travis CI" This reverts commit f7a55ec. * ci: fetch all histories in the target branch to avoid the following error from :sonarqube task > Could not find ref: master in refs/heads, refs/remotes/upstream or refs/remotes/origin * ci: use token to pass Git auth https://github.blog/2012-09-21-easier-builds-and-deployments-using-git-over-https-and-oauth/\#using-oauth-with-git * ci: sign Eclipse plugin * ci: migrate pages deployment to Actions * ci: simplify the sign procedure on the master branch refs spotbugs/spotbugs-gradle-plugin@ef626ad * ci: stop using Travis CI for better performance * ci: disable needless build scan * build: introduce Gradle Build Cache this feature was disabled by #1061 unexpectedly * ci: enable buildscan temporally * ci: run CI build in parallel * build: bump up Gradle to 6.5 * ci: disable build cache and build scan to enable build cache, we need to keep the server running, with enough RAM. but it is too expencive to keep, and its effect is not so big. * docs: replace the build badge in README.md

KengoTODA and others added 9 commits January 15, 2020 15:37

build: bump up Gradle to 6.0.1

f20884f

build: make the build pass with Gradle 6.0.1

87d2efd

build: apply api and impl separation

7f3383f

https://docs.gradle.org/current/userguide/java_library_plugin.html\#sec:java_library_separation

style: apply spotless

55b877e

build: expose dom4j and commons-lang

659627f

build: expose spotbugs

c122544

build: adjust dependencies

95221d8

build: fix configuration to use

5b4c562

build: exclude executionData file that is not exist

add0562

KengoTODA self-assigned this Jan 16, 2020

KengoTODA and others added 6 commits January 16, 2020 12:13

build: bump up jacoco to the latest ver.

96ffe22

build: set executionData in config phase, or JacocoReport task will n…

038cca0

…ot run

build: bump up Gradle to 6.1

b50dfbc

Revert "build: bump up jacoco to the latest ver."

68c0659

This reverts commit 96ffe22.

build: skip jacoco task if project has no test code

a37e2f5

build: bump up jacoco to 0.8.5

36071a1

KengoTODA marked this pull request as ready for review January 16, 2020 10:39

KengoTODA changed the title ~~build: bump up Gradle to v6~~ WIP: build: bump up Gradle to v6 Jan 16, 2020

ci: run javadoc task in CI build

4373b10

KengoTODA changed the title ~~WIP: build: bump up Gradle to v6~~ build: bump up Gradle to v6 Jan 16, 2020

KengoTODA added 4 commits January 16, 2020 19:13

docs: explain the difference with the previous version

08125b7

build: disable build cache that makes coverage report missing

a570ad3

ci: make sure jacocoRootReport runs after the test

3d09253

build: disable build cache that makes coverage report missing

048dd44

KengoTODA changed the title ~~build: bump up Gradle to v6~~ WIP: build: bump up Gradle to v6 Jan 16, 2020

KengoTODA added 3 commits January 16, 2020 21:50

build: make sure jacocoRootReport generates necessary XML file

b5f8f0a

ci: optimize gradle options

9392a3a

build: optimize sonarqube config

e52b917

KengoTODA added 3 commits January 16, 2020 22:02

build: fix config for sonarqube

357a21c

build: stop using jacoco for eclipsePlugin-test project

285f55d

build: stop using jacoco for eclipsePlugin-test project

d4fc3ec

KengoTODA changed the title ~~WIP: build: bump up Gradle to v6~~ build: bump up Gradle to v6 Jan 16, 2020

ThrawnCA approved these changes Jan 16, 2020

View reviewed changes

KengoTODA merged commit f716edc into master Jan 16, 2020

KengoTODA deleted the gradle-6 branch January 16, 2020 23:58

iloveeclipse mentioned this pull request Jan 21, 2020

Latest 4.0.0 Eclipse plugin is not functional #1067

Closed

KengoTODA mentioned this pull request Feb 3, 2020

Release RC3 with a fix around deployment #1078

Merged

KengoTODA added a commit that referenced this pull request Jun 7, 2020

build: introduce Gradle Build Cache

3a034bb

this feature was disabled by #1061 unexpectedly

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: bump up Gradle to v6#1061

build: bump up Gradle to v6#1061
KengoTODA merged 26 commits into
masterfrom
gradle-6

KengoTODA commented Jan 16, 2020 •

edited

Loading

Uh oh!

KengoTODA commented Jan 16, 2020

Uh oh!

KengoTODA commented Jan 16, 2020

Uh oh!

sonarqubecloud Bot commented Jan 16, 2020

Uh oh!

KengoTODA commented Jan 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

KengoTODA commented Jan 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KengoTODA commented Jan 16, 2020

Uh oh!

KengoTODA commented Jan 16, 2020

Uh oh!

sonarqubecloud Bot commented Jan 16, 2020

Uh oh!

KengoTODA commented Jan 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KengoTODA commented Jan 16, 2020 •

edited

Loading