Fix duckdb & sqlite character_length scalar unparsing #59
+140
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrebnov
reviewed
Nov 13, 2024
sgrebnov
approved these changes
Nov 13, 2024
peasee
approved these changes
Nov 13, 2024
peasee
left a comment
There was a problem hiding this comment.
A couple minor comments for naming. Otherwise looks good!
…le::CharacterLength
peasee
approved these changes
Nov 13, 2024
This was referenced Nov 13, 2024
Merged
Sevenannn
added a commit
that referenced
this pull request
Nov 14, 2024
* Fix duckdb & sqlite character_length scalar unparsing * Add comments * Update CharacterLengthStyle::SQLStandard to CharacterLengthExtractStyle::CharacterLength
phillipleblanc
pushed a commit
that referenced
this pull request
Nov 18, 2024
* Fix duckdb & sqlite character_length scalar unparsing (#59) * Fix duckdb & sqlite character_length scalar unparsing * Add comments * Update CharacterLengthStyle::SQLStandard to CharacterLengthExtractStyle::CharacterLength * Fix clippy error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
no such function: character_lengtherror spiceai#3315character_lengthspiceai#3168Rationale for this change
When unparsing
CharacterLengthFuncscalar function to DuckDB & SQLite syntax SQL query, theCharacterLengthFuncscalar function need to be unparsed tolength, sincelengthis the equivalence ofCharacterLengthFuncin DuckDB & SQLite.DuckDB length()
SQLite length()
What changes are included in this PR?
DuckDBDialect, which implements theDialecttraitcharacter_length_styleforDialecttrait for determining theCharacterLengthStyleto use for a dialectcharacter_length_to_sql, which unparses theCharacterLengthFunctolengthorcharacter_lengthbased onCharacterLengthStyleAre these changes tested?
Yes
Are there any user-facing changes?
No