Merged
Conversation
Member
Author
|
Changes visible in my read the docs fork http://sphinx-gallery-local.readthedocs.org/en/cssclean/ |
If the code outputs no images the is no good reason to put the multiple images list CSS environment
Contributor
|
I really think that the fact that you are relying on SCSS is a problem. It means that only you master the workflow to edit the CSS. As such this is a limiting factor to bringing in contributions. Right now you are the main developer by far, so it's more beneficial that harmful. If I were you, I would train myself to work without SCSS, because it makes you more powerful. |
Contributor
|
+1 the size of our css file is not huge to justify the use of scss my 2c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix #73
I have moved all the changes from the latest CSS version in the gallery back to the SCSS. The SCSS file is now linted with scss-lint and the resulting CSS file is exported in expanded form instead of the default nested.