updated mpl gui warning catcher to new error message#1160
Merged
larsoner merged 2 commits intosphinx-gallery:masterfrom Aug 10, 2023
Merged
updated mpl gui warning catcher to new error message#1160larsoner merged 2 commits intosphinx-gallery:masterfrom
larsoner merged 2 commits intosphinx-gallery:masterfrom
Conversation
larsoner
approved these changes
Aug 10, 2023
larsoner
requested changes
Aug 10, 2023
Contributor
larsoner
left a comment
There was a problem hiding this comment.
I just realized that this will only work for newer matplotlib. The regex should support both old and new matplotlib verisons, which you can accomplish with (old|new) for example
0019742 to
030d075
Compare
Contributor
Author
|
no problem, wasn't sure how back compatibility is handled here. |
030d075 to
1e5ce2b
Compare
larsoner
reviewed
Aug 10, 2023
a2da63b to
f46a3f7
Compare
larsoner
reviewed
Aug 10, 2023
f46a3f7 to
3949233
Compare
Contributor
Author
|
Is no problem, this isn't even a cranky review cycle. |
Contributor
Looks like the CIs are still cranky about style 😄 |
auto-merge was automatically disabled
August 10, 2023 18:27
Head branch was pushed to by a user without write access
3949233 to
67629ce
Compare
Contributor
Author
|
I'm clearly spoiled by pre-commits |
larsoner
reviewed
Aug 10, 2023
Contributor
clrpackages
referenced
this pull request
in clearlinux-pkgs/pypi-sphinx_gallery
Aug 22, 2023
… to version 0.14.0 v0.14.0 ------- **Implemented enhancements:** - MAINT Update backreferences docs and add tests `#1154 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1154>`__ (`lucyleeow <https://github.com/lucyleeow>`__) - Remove extra spaces in reported running time `#1147 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1147>`__ (`stefanv <https://github.com/stefanv>`__) **Fixed bugs:** - MAINT: Fix for Sphinx 7.2 `#1176 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1176>`__ (`larsoner <https://github.com/larsoner>`__) - updated mpl gui warning catcher to new error message `#1160 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1160>`__ (`story645 <https://github.com/story645>`__) - Ensure consistent encoding for md5sum generation `#1159 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1159>`__ (`sdhiscocks <https://github.com/sdhiscocks>`__) - Maint: Fix ``app.builder.outdir`` as Sphinx now using pathlib `#1155 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1155>`__ (`lucyleeow <https://github.com/lucyleeow>`__) - Make \_LoggingTee compatible with TextIO `#1151 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1151>`__ (`o-laurent <https://github.com/o-laurent>`__) (NEWS truncated at 15 lines)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks, matplotlib/matplotlib#26472 changed the wording of the gui error message, so this PR updates the filters and docs to the new warning message wording. This is gonna be in the 3.8 release.
I wonder if there's a better way to do this though.