Do not close figures on backend switch.#26472
Merged
ksunden merged 1 commit intomatplotlib:mainfrom Aug 8, 2023
Merged
Conversation
Do not `close("all")` figures on (allowable) backend switches, e.g.
between qt5agg and qt5cairo, or qt5agg and notebook.
The NonGuiException message had to change, as the backend returned by
get_backend() may no longer match the actual canvas class.
tacaswell
approved these changes
Aug 8, 2023
Member
tacaswell
left a comment
There was a problem hiding this comment.
I'm in favor of squeezing this in for 3.8.
It is a super edge-case but would be good to get done.
ksunden
approved these changes
Aug 8, 2023
Member
|
Test failure is known flaky test (test_blit) |
story645
added a commit
to story645/matplotlib
that referenced
this pull request
Aug 9, 2023
story645
added a commit
to story645/matplotlib
that referenced
this pull request
Aug 9, 2023
Co-authored-by: Kyle Sunden <git@ksunden.space>
story645
added a commit
to story645/matplotlib
that referenced
this pull request
Aug 9, 2023
Co-authored-by: Kyle Sunden <git@ksunden.space>
This was referenced Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not
close("all")figures on (allowable) backend switches, e.g. between qt5agg and qt5cairo, or qt5agg and notebook.The NonGuiException message had to change, as the backend returned by get_backend() may no longer match the actual canvas class.
Closes #15913. (Redo of #15918; see also #14471.)
PR summary
PR checklist