Allow case-insensitive match of :term: references through intersphinx#9299
Merged
tk0miya merged 2 commits intosphinx-doc:4.xfrom Jul 11, 2021
Merged
Conversation
AWhetter
reviewed
Jun 4, 2021
Only looks for case insensitive match if there isn't a case sensitive one, and uses filter to build a list of case insensitive matches rather than building a dict.
Member
|
LGTM! Could you add a testcase for this, please? |
Contributor
Author
|
I haven't abandoned this - been busy with the project that needs the fix, will add test cases when I have some time available. |
tk0miya
added a commit
that referenced
this pull request
Jul 11, 2021
Member
|
Now I added a testcase for this and merged. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject: Allow case-insensitive match of :term: references through intersphinx
Feature or Bugfix
Purpose
Detail
Simple code change, detects that the objtype is
std:term, builds a dict of lower case to original case for all keys in the inventory under inspection and uses that to perform case insensitive matching.Relates