Fix #8175: intersphinx: Potential of regex denial of service by inventory#8225
Merged
tk0miya merged 1 commit intosphinx-doc:3.xfrom Sep 28, 2020
Merged
Fix #8175: intersphinx: Potential of regex denial of service by inventory#8225tk0miya merged 1 commit intosphinx-doc:3.xfrom
tk0miya merged 1 commit intosphinx-doc:3.xfrom
Conversation
4383819 to
f7b872e
Compare
bskinn
added a commit
to bskinn/sphobjinv
that referenced
this pull request
Feb 7, 2021
Celery has some duplicate objects in the inventory, which Sphinx ignores but sphobjinv does not. OpenCV has objects that are not parsed correctly by Sphinx after the regex change in sphinx-doc/sphinx#8225, but that sphobjinv currently reads without difficulty. A decision will have to be made whether to follow sphinx#8225's fix for the DOS potential reported in sphinx#8175, or implement one of the other less-susceptible regexes suggested in sphinx#8175. Prefer the latter option, as it won't require post-processing of a combined domain:role.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose