classic theme: default codetextcolor/codebgcolor doesn't override Pygments#7721
Merged
tk0miya merged 1 commit intosphinx-doc:3.xfrom Jun 5, 2020
Merged
classic theme: default codetextcolor/codebgcolor doesn't override Pygments#7721tk0miya merged 1 commit intosphinx-doc:3.xfrom
tk0miya merged 1 commit intosphinx-doc:3.xfrom
Conversation
This was referenced May 24, 2020
Member
|
LGTM. Can I merge this instead of #7720? |
Contributor
Author
Yes, please! |
Member
|
Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A much better alternative to #7720.
With this PR, the Pygments colors (including background and text for
'none'language) are used by default for code blocks.However,
codetextcolor/codebgcolorcan still be used to override the colors.Therefore, I wouldn't call this a "breaking" change (but this is debatable).