Regression fixup: respect anchor-check configuration setting#11544
Merged
AA-Turner merged 8 commits intosphinx-doc:7.1.xfrom Aug 2, 2023
jayaddison:issue-11542/anchor-linkcheck-regression
Merged
Regression fixup: respect anchor-check configuration setting#11544AA-Turner merged 8 commits intosphinx-doc:7.1.xfrom jayaddison:issue-11542/anchor-linkcheck-regression
AA-Turner merged 8 commits intosphinx-doc:7.1.xfrom
jayaddison:issue-11542/anchor-linkcheck-regression
Conversation
AA-Turner
reviewed
Aug 1, 2023
AA-Turner
reviewed
Aug 1, 2023
francoisfreitag
approved these changes
Aug 1, 2023
Member
|
Looking good. Maybe also add a mention to the release note? |
…n anchor checking is not enabled
… linkcheck builder tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
linkcheck_anchorssetting was not being respected.Detail
linkcheckbuilder code has been attempting to read content from these responses.Relates