linkcheck builder: don't retry with HTTP GET after SSLError on HTTP HEAD#11431
Merged
AA-Turner merged 5 commits intosphinx-doc:masterfrom Jul 20, 2023
jayaddison:issue-9592/fixup-consider-sslerror-non-retryable
Merged
linkcheck builder: don't retry with HTTP GET after SSLError on HTTP HEAD#11431AA-Turner merged 5 commits intosphinx-doc:masterfrom jayaddison:issue-9592/fixup-consider-sslerror-non-retryable
AA-Turner merged 5 commits intosphinx-doc:masterfrom
jayaddison:issue-9592/fixup-consider-sslerror-non-retryable
Conversation
Contributor
Author
|
Thank you, @francoisfreitag! |
…ryable # Conflicts: # sphinx/builders/linkcheck.py
Contributor
Author
|
Thanks, @AA-Turner! |
This was referenced Aug 1, 2023
AA-Turner
pushed a commit
that referenced
this pull request
Aug 2, 2023
AA-Turner
pushed a commit
that referenced
this pull request
Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
SSLErroroccurs following an HTTP HEAD operation, it seems unlikely that a subsequent HTTP GET will succeed, so don't attempt one.Detail
SSLErrorexception that can be raised byrequestsis a subclass ofConnectionError, so our logic to handle HTTP HEAD request failures has allowed an HTTP GET to occur as a fallback.Relates