Skip to content

Change "headline" to "heading"#10048

Merged
tk0miya merged 1 commit intosphinx-doc:masterfrom
pradyunsg:change-heading-anchor-tooltip
Jan 2, 2022
Merged

Change "headline" to "heading"#10048
tk0miya merged 1 commit intosphinx-doc:masterfrom
pradyunsg:change-heading-anchor-tooltip

Conversation

@pradyunsg
Copy link
Contributor

Feature or Bugfix

  • Bugfix?

Relates

Closes #10041, which has the relevant discussion and context.

"heading" is a better word to use in this tooltip, since it better
matches the use case.
@pradyunsg
Copy link
Contributor Author

mypy run-test: commands[0] | mypy sphinx/
sphinx/directives/patches.py: note: In member "run" of class "Meta":
sphinx/directives/patches.py:86:16: error: Incompatible return value type (got "Sequence[Node]", expected "List[Node]")
Found 1 error in 1 file (checked 177 source files)

The mypy failure seems unrelated.

@tk0miya tk0miya added builder:html type:proposal a feature suggestion labels Jan 2, 2022
@tk0miya tk0miya added this to the 5.0.0 milestone Jan 2, 2022
@tk0miya tk0miya merged commit 3cb680a into sphinx-doc:master Jan 2, 2022
@tk0miya
Copy link
Member

tk0miya commented Jan 2, 2022

Thanks!

@pradyunsg pradyunsg deleted the change-heading-anchor-tooltip branch January 2, 2022 16:23
akdor1154 pushed a commit to akdor1154/sphinx that referenced this pull request Jan 7, 2022
akdor1154 pushed a commit to akdor1154/sphinx that referenced this pull request Jan 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

builder:html type:proposal a feature suggestion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants