Remove underline from whitespace#188
Closed
tunetheweb wants to merge 1 commit intosphinx-doc:masterfrom
Closed
Conversation
6 tasks
introt
added a commit
to introt/alabester
that referenced
this pull request
Apr 21, 2022
sphinx-doc#188 Co-authored-by: Barry Pollard <10931297+tunetheweb@users.noreply.github.com>
|
Still getting this issue with Sphinx 6.1.3, Alabaster 0.7.13, and Pygments 2.14.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest version of pygments seems to have started applying the
wclass to whitespace, which looks bad for code samples:Especially in dark theme or when selected:
They can't see why the
wclass has a text underline and removed it, but Alabaster has it explicitly set so need to remove it here too.