Switch to implicit (native) namespace#75
Conversation
Drop support for Python 3.6 and older. Fix tests. Run tests on GHA.
As it is already done for (nearly) all other packages in this namespace.
|
Plone 6.2 will switch to implicit, or more precisely in its case, native namespaces. See plone/Products.CMFPlone#3928 (comment) In that regard, it would be good to align the upper Python versions with Plone 6.2 for compatibility. @icemac I'd be happy to help push this forward. |
|
@stevepiercy Thank you for your offer of help. Currently it requires travis-ci to be green instead of GHA, are you allowed to change it in the settings? |
|
@icemac I don't have any access to this repo's settings. Is that something you can grant, or do we need to go through this process? |
|
btw, if @datakurre doesn't have access to this repo's settings, I'd suggest adding him as well. |
|
@stevepiercy I am just a simple member in this project with no adminstrative rights, I have no idea how it works for this organization to get adminstrative rights. |
|
@icemac OK, I see now. I assumed you were. @dahlia @ashb @dhellmann @stephenfin I think that you are maintainers or administrators of this project on either GitHub or PyPI. Would you please grant the following users access to manage this repository and make releases to PyPI? @icemac If this is not the correct process, please let me know. Thank you! |
mauritsvanrees
left a comment
There was a problem hiding this comment.
LGTM. Would be good to get this merged and have a release. The last release is from 2022.
@icemac Maybe it helps if you rebase this on the main branch, so there is only one commit?
|
One more attempt. @dahlia @ashb @dhellmann @stephenfin I think that you are maintainers or administrators of this project on either GitHub or PyPI. Would you please grant the following users access to manage this repository and make releases to PyPI? @icemac If this is not the correct process, please let me know. Thank you! |
|
Hi @stevepiercy, Apologies for the delay—I've been inactive on this project for quite some time and haven't been monitoring notifications closely. I'll grant repository admin access to @icemac, @stevepiercy, and @datakurre. For PyPI, could you let me know your PyPI usernames? I'll add you as maintainers once I have them. I also want to follow up on #83—@AA-Turner offered to help maintain the project, and I'd welcome that too. If anyone wants to take over as the primary maintainer, I'm happy to step back entirely. Thanks for keeping this project alive! |
|
Sorry for missing your earlier comment! Happy to be added as a maintainer. My username on PyPI / read the docs is the same as on GitHub. A |
I'm |
|
Thanks again for PyPI access @dahlia! If anyone else wants to merge and release this version, please go ahead. I'll try to get to it next week, if no one else has done so by then. It would be good to switch from Travis CI to GitHub Actions, too, but that can be done after a release, as I don't think it'll change the distribution. |
|
Thank you @dahlia. @stevepiercy Please do next week. I am not up-to-date with this enough to feel comfortable to do anything in hurry. |
|
@datakurre me, too. I'm not in a rush. Plone 6.2 is targeted for a release next week, but this PR is for documentation only, not core functionality of Plone (although I have the opinion of "If it ain't documented, it's broken"), and I think we can take our time. I'd also like to document the release process for future maintainers, and maybe use zest.releaser, since I'm familiar with it and it has helped me avoid critical mistakes. If anyone has other suggestions, I'm open to them. |
|
It's secondary to this PR and probably something that warrants it's own ticket, but have we considered merging this into upstream docutils? It likely has broad enough adoption and is simple enough to warrant it at this point. |
|
this == A |
|
I've opened a PR that will run tests in GitHub Actions at #85. Would y'all please take a moment to review it? That PR will help determine whether it's safe to merge this one. Thank you! |
Yes |
This PR provides a basic check via GitHub Actions instead of Travis CI. Sets up #75, and other PRs, for a safer merge.
|
@stevepiercy A review of a person with write access is needed, could you be the one? |
stevepiercy
left a comment
There was a problem hiding this comment.
Thank you, @icemac!
|
@icemac would you please rebase your branch on |
|
@AA-Turner and @stephenfin I've created a new discussion for the topic you brought up at #88 |
|
I don't know what was wrong with GitHub, so I merged this on the command line. |
This PR also contains the changes of #74 as it is based on it.