@lan496 One final task that I noticed with #498 there are sections where we are calling the deprecated interface of DictInterface, e.g.

Lines 1094 to 1098 in 9acbe6d

    
           spg_type = get_spacegroup_type(dataset["hall_number"]) 
        
           if symbol_type == 1: 
        
               return "%s (%d)" % (spg_type["schoenflies"], dataset["number"]) 
        
           else: 
        
               return "%s (%d)" % (spg_type["international_short"], dataset["number"])

And I've been thinking about

spglib/python/spglib/spglib.py

Lines 92 to 98 in 9acbe6d

    
           Lattice: TypeAlias = Sequence[Sequence[float]] 
        
           Positions: TypeAlias = Sequence[Sequence[float]] 
        
           Numbers: TypeAlias = Sequence[int] 
        
           Magmoms: TypeAlias = Sequence[float] | Sequence[Sequence[float]] 
        
           Cell: TypeAlias = ( 
        
               tuple[Lattice, Positions, Numbers] | tuple[Lattice, Positions, Numbers, Magmoms] 
        
           )

I think those are better outside of the TYPE_CHECKING. Reasoning is that I was thinking how to deal with the complex documentation like Cell and I think that it can be incorporated in the TypeAlias itself, but that would require to move the definition outside conditional, especially for IDE support.

	spg_type = get_spacegroup_type(dataset["hall_number"])
	if symbol_type == 1:
	return "%s (%d)" % (spg_type["schoenflies"], dataset["number"])
	else:
	return "%s (%d)" % (spg_type["international_short"], dataset["number"])

	Lattice: TypeAlias = Sequence[Sequence[float]]
	Positions: TypeAlias = Sequence[Sequence[float]]
	Numbers: TypeAlias = Sequence[int]
	Magmoms: TypeAlias = Sequence[float] \| Sequence[Sequence[float]]
	Cell: TypeAlias = (
	tuple[Lattice, Positions, Numbers] \| tuple[Lattice, Positions, Numbers, Magmoms]
	)

Release v2.5.0 #486

Description

TODO

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions