Add SpglibDataset and SpglibMagneticDataset and dataclass#490
Merged
lan496 merged 3 commits intospglib:developfrom Jun 10, 2024
Merged
Add SpglibDataset and SpglibMagneticDataset and dataclass#490lan496 merged 3 commits intospglib:developfrom
SpglibDataset and SpglibMagneticDataset and dataclass#490lan496 merged 3 commits intospglib:developfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #490 +/- ##
========================================
Coverage 83.90% 83.90%
========================================
Files 25 25
Lines 8184 8184
Branches 1701 1701
========================================
Hits 6867 6867
Misses 1317 1317
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LecrisUT
approved these changes
Jun 8, 2024
Collaborator
LecrisUT
left a comment
There was a problem hiding this comment.
Sorry, I had this pending review, but forgot to hit submit review. Only 1 minor note
LecrisUT
approved these changes
Jun 9, 2024
Member
Author
|
@LecrisUT These required test failed somehow. Can you check it? |
Collaborator
|
Fedora 40 was released so F38 was retired. This changes every 6 months unfortunately |
Member
Author
|
I see. I've updated the branch protection rule. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
dataclasses.dataclassforget_symmetry_datasetandget_magnetic_symmetry_datasetin Python API.