Merged
Conversation
0a1bcd7 to
7ca81b3
Compare
7ca81b3 to
468860b
Compare
468860b to
0782b3a
Compare
This was referenced Dec 6, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new constructor for Viper and a functional option for the key delimiter. This is an initial solution for supporting keys containing the key delimiter.
For the mid-term, I would probably add back the feature reverted in #771 (and fixed in #766) with a feature flag
v.AllowDelimiterInKeydefaulting to false. That changes the behavior of Viper though (see #766 (comment)) which is why we need the flag, defaulting to false.cc @inkychris @mschneider82