Skip to content

Revert unmarshal keys containing dots#771

Merged
sagikazarmark merged 2 commits intomasterfrom
revert-unmarshal-keys-containing-dots
Sep 28, 2019
Merged

Revert unmarshal keys containing dots#771
sagikazarmark merged 2 commits intomasterfrom
revert-unmarshal-keys-containing-dots

Conversation

@sagikazarmark
Copy link
Collaborator

This PR reverts #673 because it introduced a breaking change.

Fixes #764

@sagikazarmark sagikazarmark force-pushed the revert-unmarshal-keys-containing-dots branch from 6ad0839 to 141d214 Compare September 27, 2019 15:27
@sagikazarmark
Copy link
Collaborator Author

@inkychris would you mind taking a quick look at this PR? 🙂

@inkychris
Copy link
Contributor

It looks good to me!

@sagikazarmark
Copy link
Collaborator Author

Thanks!

@sagikazarmark sagikazarmark merged commit 71509d2 into master Sep 28, 2019
@sagikazarmark sagikazarmark deleted the revert-unmarshal-keys-containing-dots branch September 28, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR #673 broke my code. The nested structures don't get the default values correctly

2 participants