Added more const for external reference to external.go#188
Added more const for external reference to external.go#188
Conversation
-added more const for external.go, from the PR spdx#153 Signed-off-by: Neil Naveen <42328488+neilnaveen@users.noreply.github.com>
lumjjb
left a comment
There was a problem hiding this comment.
Thanks @neilnaveen for opening this up!
kzantow
left a comment
There was a problem hiding this comment.
Hey @neilnaveen if you are going to add these constants (which seems good 👍), could you add all the constants defined in the external references categories and annex f types?
Also these need aliases in the spdx/model.go.
I'd second @lumjjb 's request to replace the hardcoded values with these constants where appropriate, too. I think it would make sense to be part of this PR.
Signed-off-by: Neil Naveen <42328488+neilnaveen@users.noreply.github.com>
I have added all constants from the annex f types, and I have put them in their respective categories. |
kzantow
left a comment
There was a problem hiding this comment.
Hi @neilnaveen this PR stills seems to be missing a number of changes from the original PR: https://github.com/spdx/tools-golang/pull/153/files it also does not include the aliases in the spdx package, are you able to fix this?
Signed-off-by: Neil Naveen <42328488+neilnaveen@users.noreply.github.com>
I have added aliases into spdx/model.go. Could you also tell me which changes I have not added in this PR that was in #153? |
Signed-off-by: Neil Naveen <42328488+neilnaveen@users.noreply.github.com>
Signed-off-by: Neil Naveen 42328488+neilnaveen@users.noreply.github.com