Fixed Bug For DocumentComment in v2_3#187
Merged
Conversation
kzantow
requested changes
Jan 27, 2023
kzantow
reviewed
Jan 27, 2023
Collaborator
|
@neilnaveen do you think you will be able to get to the aforementioned changes in the next few days? We would like to get this done fairly soon due to the |
Contributor
Author
I will try to work on it this week. |
- added test for DocumentComment switch case Signed-off-by: Neil Naveen <42328488+neilnaveen@users.noreply.github.com>
84e8b06 to
ce7f841
Compare
- changed switch case for documentComment in v2_2 - changed test for documentComment in v2_2 - removed parse_document and parse_document_test in v2_2 - added switch case for documentComment in v2_3 - added test for DocumentComment switch case in v2_3 Signed-off-by: Neil Naveen <42328488+neilnaveen@users.noreply.github.com>
7c85f05 to
f24f472
Compare
kzantow
approved these changes
Feb 1, 2023
Collaborator
kzantow
left a comment
There was a problem hiding this comment.
Great, thanks @neilnaveen !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concerning issue #186
Signed-off-by: Neil Naveen 42328488+neilnaveen@users.noreply.github.com