Merged
Conversation
- added DocumentComment switch case for tag in parse_creation_info.go - added test for DocumentComment switch case - added file parse_document.go for the switch case above - added test for parse_document.go Signed-off-by: Neil Naveen <42328488+neilnaveen@users.noreply.github.com>
fbe2f9b to
ccf8e63
Compare
lumjjb
approved these changes
Jan 26, 2023
Collaborator
lumjjb
left a comment
There was a problem hiding this comment.
LGTM! Thanks @neilnaveen
kzantow
reviewed
Jan 26, 2023
Collaborator
kzantow
left a comment
There was a problem hiding this comment.
This change should also be applied to spdx/v2/v2_3/tagvalue/... files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses issue #182
Signed-off-by: Neil Naveen 42328488+neilnaveen@users.noreply.github.com