Skip to content

Enforce RunAtLoad and remove KeepAlive#2795

Merged
zorgiepoo merged 1 commit into2.xfrom
push-pkpppqkosrou
Nov 8, 2025
Merged

Enforce RunAtLoad and remove KeepAlive#2795
zorgiepoo merged 1 commit into2.xfrom
push-pkpppqkosrou

Conversation

@zorgiepoo
Copy link
Copy Markdown
Member

@zorgiepoo zorgiepoo commented Oct 31, 2025

Overriding KeepAlive before actually implies RunAtLoad is true but we were setting RunAtLoad to false which is conflicting. In any case we don't want to restart the job if it crashes, and we want to run Updater when the job is loaded.

Regarding discussion #2794

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)
  • Tested updating app on several OS versions.
  • Confirmed RunAtLoad is needed (without KeepAlive) otherwise Updater job won't start

macOS version tested: 26.0.1 (25A362)
macOS 12 VM
macOS 10.14 VM

Overriding KeepAlive before actually implies RunAtLoad is true but we were setting RunAtLoad to false which is conflicting. In any case we don't want to restart the job if it crashes, and we want to run Updater when the job is loaded.
@zorgiepoo zorgiepoo added this to the 2.8.1 milestone Oct 31, 2025
@zorgiepoo zorgiepoo merged commit f80d063 into 2.x Nov 8, 2025
2 checks passed
@zorgiepoo zorgiepoo deleted the push-pkpppqkosrou branch November 8, 2025 16:19
zorgiepoo added a commit that referenced this pull request Nov 15, 2025
Overriding KeepAlive before actually implies RunAtLoad is true but we were setting RunAtLoad to false which is conflicting. In any case we don't want to restart the job if it crashes, and we want to run Updater when the job is loaded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant