Skip to content

Double quote team identifiers in designated requirement strings#2766

Merged
zorgiepoo merged 1 commit into2.xfrom
push-zslxzqyqpwvr
Sep 9, 2025
Merged

Double quote team identifiers in designated requirement strings#2766
zorgiepoo merged 1 commit into2.xfrom
push-zslxzqyqpwvr

Conversation

@zorgiepoo
Copy link
Copy Markdown
Member

@zorgiepoo zorgiepoo commented Sep 9, 2025

Fixes #2765

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Verified update process works in my notarized test app (I don't have a team ID that starts with a number so testing is limited). Verified newer and legacy code signing requirement paths are still hit. This fix has also been tested by reporter in #2765.

macOS version tested:
15.5 (24F74)
10.14.6 VM

@zorgiepoo zorgiepoo merged commit 167db6f into 2.x Sep 9, 2025
2 checks passed
@zorgiepoo zorgiepoo deleted the push-zslxzqyqpwvr branch September 9, 2025 12:53
zorgiepoo added a commit that referenced this pull request Sep 9, 2025
Fixes #2765 which is a crash if team ID starts with a number.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autoupdate Crashes For Certain Team IDs With Version 2.7.2

1 participant