cleanup: Sepolia refactor (SC-745)#40
Merged
lucas-manuel merged 10 commits intoSC-706-sepolia-supportfrom Oct 15, 2024
Merged
Conversation
hexonaut
approved these changes
Oct 15, 2024
Contributor
hexonaut
left a comment
There was a problem hiding this comment.
After sanity check for less than 1m is fixed then good to merge.
hexonaut
approved these changes
Oct 15, 2024
|
Coverage after merging sc-745-sepolia-refactor into SC-706-sepolia-support will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
hexonaut
added a commit
that referenced
this pull request
Oct 15, 2024
* feat: add deployments and testing * fix: formatting * feat: get deployy tests working, refactor structure * feat: get deployy tests working, refactor structure * feat: finish deploy scripts refactor * feat: add init * feat: add init * feat: mainnet deploy and init working * feat: tests passing * fix: cleanup * feat: update to use interfaces * fix: alignment and struct * feat: update to add separate init scripts * feat: check constructor params * feat: add unlimited rate data sanity checks * feat: get constructor tests working * feat: update to add rate limit tests * feat: add init failure tests for mainnet controller * feat: update to add remaining failure mode tests * starting on sepolia support * more work on sepolia testnet * move usds join back to common * more work on sepolia support * forge install: erc20-helpers * more progress on sepolia deploy * mint usds working * got psm swap working * started on base * starting on base * almost finished base support * forge install: dss-test * full sepolia working * add safe * forge install: safe-smart-account v1.4.1 * fix imports * create deploy * update to latest alm controller and add vat ilk line * add more addresses * remove safe deploy logic; new sepolia release * use 1 for rate * cleanup: Sepolia refactor (SC-745) (#40) * formatting: regroup and reorder imports * formatting: set up declarations, change function naming * formatting: general formatting throughout * formatting: add step by step comments, move function * fix: update remappings, update instance name * fix: move variable assignments * feat: update to mint funds to alm proxy and use psm deploy lib * fix: rm comment * fix: sanity check and psm lib --------- Co-authored-by: lucas-manuel <lucasmanuel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
_setBaseMintRecipient