Skip to content

Add libs attribute to mesa and mesa-glu packages#8904

Merged
alalazo merged 1 commit intospack:developfrom
adamjstewart:packages/glu
Aug 7, 2018
Merged

Add libs attribute to mesa and mesa-glu packages#8904
alalazo merged 1 commit intospack:developfrom
adamjstewart:packages/glu

Conversation

@adamjstewart
Copy link
Copy Markdown
Member

@adamjstewart adamjstewart commented Aug 6, 2018

Also fix dependency version in glvis package.
Fixes build errors mentioned in #8454.

@imnasnainaec Can you see if this solves all of your build problems?

@adamjstewart
Add libs attribute to mesa and mesa-glu packages
852b83e 
Also fix dependency version in glvis package.
Fixes build errors mentioned in spack#8454.
@adamjstewart adamjstewart requested a review from v-dobrev August 6, 2018 22:38
@v-dobrev v-dobrev mentioned this pull request Aug 6, 2018
Merged
@imnasnainaec
Copy link
Copy Markdown

imnasnainaec commented Aug 7, 2018 •
edited
Loading

@adamjstewart I manually made all the same edits as proposed here and it appears to have worked:

==> Installing glvis
==> Using cached archive: /home/dror/spack/var/spack/cache/glvis/glvis-3.4.tar.gz
==> Staging archive: /home/dror/spack/var/spack/stage/glvis-3.4-4mnjl7sqdybr2bvd346zc7fzv43lorja/glvis-3-4
==> Created stage in /home/dror/spack/var/spack/stage/glvis-3.4-4mnjl7sqdybr2bvd346zc7fzv43lorja
==> No patches needed for glvis
==> Building glvis [MakefilePackage]
==> Executing phase: 'edit'
==> Executing phase: 'build'
==> Executing phase: 'install'
==> Successfully installed glvis
Fetch: 0.00s. Build: 11.71s. Total: 11.71s.
[+] /home/dror/spack/opt/spack/linux-ubuntu18.04-x86_64/gcc-7.3.0/glvis-3.4-4mnjl7sqdybr2bvd346zc7fzv43lorja

@adamjstewart
Copy link
Copy Markdown
Member Author

adamjstewart commented Aug 7, 2018

@imnasnainaec Glad to hear it! Thanks for reporting this bug.

alalazo
alalazo approved these changes Aug 7, 2018
View reviewed changes
Comment thread var/spack/repos/builtin/packages/opengl/package.py
shared=True, recursive=False)
if libs:
return libs
return None
Copy link
Copy Markdown
Member

@alalazo alalazo Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@alalazo alalazo merged commit 79e7359 into spack:develop Aug 7, 2018
@adamjstewart adamjstewart deleted the packages/glu branch August 7, 2018 13:45
anderson2981 pushed a commit to anderson2981/spack that referenced this pull request Sep 7, 2018
@adamjstewart @anderson2981
Add libs attribute to mesa and mesa-glu packages (spack#8904)
b05ff72 
Also fix dependency version in glvis package.
Fixes build errors mentioned in spack#8454.
v-dobrev added a commit that referenced this pull request Mar 27, 2020
@v-dobrev
[mesa] Re-introduce the libs property, originally added in
72c3fb3 
       #8904 and later removed (why?) in #10482.
@v-dobrev v-dobrev mentioned this pull request Mar 27, 2020
Merged
alalazo pushed a commit that referenced this pull request Mar 28, 2020
@v-dobrev
mesa: re-introduce the libs property (#15716)
9f7255d 
They were originally added in #8904 and later removed (why?) in #10482.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalazo alalazo alalazo approved these changes

@v-dobrev v-dobrev Awaiting requested review from v-dobrev

+1 more reviewer

@healther healther healther approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies libraries virtual-dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adamjstewart @imnasnainaec @healther @alalazo