Use no mangling for spack compiler definitions that use xlf#8392
Merged
tgamblin merged 1 commit intospack:developfrom Jun 15, 2018
Merged
Use no mangling for spack compiler definitions that use xlf#8392tgamblin merged 1 commit intospack:developfrom
tgamblin merged 1 commit intospack:developfrom
Conversation
Fortran compiler. Clang can build with IBM XL Fortran compiler as well, so the name mangling shoud be avoided for that case as well.
This was referenced Jun 5, 2018
Contributor
Author
|
@davydden Since you have reviewed some of this issue's relatives, would you be willing to review this one as well? |
davydden
approved these changes
Jun 12, 2018
davydden
reviewed
Jun 12, 2018
| 'LOADOPTS =', | ||
| 'CDEFS = %s' % ("-DNoChange" | ||
| if '%xl' in spec or '%xl_r' in spec | ||
| if spack_f77.endswith('xlf') or |
Member
There was a problem hiding this comment.
p.s. this will always be the case for
`%xl` and `%xl_r` in spec
right? In other words, you just extend the domain where if applies?
Contributor
Author
|
@adamjstewart @alalazo -- would either of you be willing to merge this PR? |
smuething
added a commit
to smuething/spack
that referenced
this pull request
Jun 18, 2018
* upstream-develop: (430 commits) There's only one 'u' in "configuration" (spack#8498) Add new versions for TAU and PDT package (spack#8497) Add changes to the Krell packages with version updates and ranges for the latest release. (spack#8468) docs: remove vendored sphinx_rtd_theme (spack#8496) Trilinos needs parallel-netcdf as an explicit dependency to avoid concretization errors when netcdf is an external. (spack#8493) superlu_dist: 'master' is branch - not tag (spack#8495) SAMRAI: new versions, handle deprecation of boost in latest version. (spack#8494) Fix GDAL Python bindings and add import tests (spack#8482) Add newer likwid versions 4.3.1 and 4.3.2 (spack#8488) Package/geopm: Update to version 0.5.0 (spack#8487) [mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST. (spack#8485) openssl: add new version 1.0.2o (spack#8486) Update the clang compiler definition to use IBM XL Fortran compiler (spack#8389) Patch trilinos for xlf when using clang (spack#8391) Use no mangling for all spack compiler definitions that use the XL (spack#8392) Use the name of the Fortran compiler to determine what name mangling (spack#8393) A new package: megahit. (spack#8471) neovim: add info for v0.3.0 (spack#8472) oce: add 0.18.3 (spack#8477) netgen should depend on zlib (spack#8473) ...
smuething
added a commit
to smuething/spack
that referenced
this pull request
Jun 18, 2018
* upstream-develop: (430 commits) There's only one 'u' in "configuration" (spack#8498) Add new versions for TAU and PDT package (spack#8497) Add changes to the Krell packages with version updates and ranges for the latest release. (spack#8468) docs: remove vendored sphinx_rtd_theme (spack#8496) Trilinos needs parallel-netcdf as an explicit dependency to avoid concretization errors when netcdf is an external. (spack#8493) superlu_dist: 'master' is branch - not tag (spack#8495) SAMRAI: new versions, handle deprecation of boost in latest version. (spack#8494) Fix GDAL Python bindings and add import tests (spack#8482) Add newer likwid versions 4.3.1 and 4.3.2 (spack#8488) Package/geopm: Update to version 0.5.0 (spack#8487) [mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST. (spack#8485) openssl: add new version 1.0.2o (spack#8486) Update the clang compiler definition to use IBM XL Fortran compiler (spack#8389) Patch trilinos for xlf when using clang (spack#8391) Use no mangling for all spack compiler definitions that use the XL (spack#8392) Use the name of the Fortran compiler to determine what name mangling (spack#8393) A new package: megahit. (spack#8471) neovim: add info for v0.3.0 (spack#8472) oce: add 0.18.3 (spack#8477) netgen should depend on zlib (spack#8473) ...
smuething
added a commit
to smuething/spack
that referenced
this pull request
Jun 18, 2018
* upstream-develop: (430 commits) There's only one 'u' in "configuration" (spack#8498) Add new versions for TAU and PDT package (spack#8497) Add changes to the Krell packages with version updates and ranges for the latest release. (spack#8468) docs: remove vendored sphinx_rtd_theme (spack#8496) Trilinos needs parallel-netcdf as an explicit dependency to avoid concretization errors when netcdf is an external. (spack#8493) superlu_dist: 'master' is branch - not tag (spack#8495) SAMRAI: new versions, handle deprecation of boost in latest version. (spack#8494) Fix GDAL Python bindings and add import tests (spack#8482) Add newer likwid versions 4.3.1 and 4.3.2 (spack#8488) Package/geopm: Update to version 0.5.0 (spack#8487) [mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST. (spack#8485) openssl: add new version 1.0.2o (spack#8486) Update the clang compiler definition to use IBM XL Fortran compiler (spack#8389) Patch trilinos for xlf when using clang (spack#8391) Use no mangling for all spack compiler definitions that use the XL (spack#8392) Use the name of the Fortran compiler to determine what name mangling (spack#8393) A new package: megahit. (spack#8471) neovim: add info for v0.3.0 (spack#8472) oce: add 0.18.3 (spack#8477) netgen should depend on zlib (spack#8473) ...
smuething
added a commit
to smuething/spack
that referenced
this pull request
Jun 18, 2018
* upstream-develop: (430 commits) There's only one 'u' in "configuration" (spack#8498) Add new versions for TAU and PDT package (spack#8497) Add changes to the Krell packages with version updates and ranges for the latest release. (spack#8468) docs: remove vendored sphinx_rtd_theme (spack#8496) Trilinos needs parallel-netcdf as an explicit dependency to avoid concretization errors when netcdf is an external. (spack#8493) superlu_dist: 'master' is branch - not tag (spack#8495) SAMRAI: new versions, handle deprecation of boost in latest version. (spack#8494) Fix GDAL Python bindings and add import tests (spack#8482) Add newer likwid versions 4.3.1 and 4.3.2 (spack#8488) Package/geopm: Update to version 0.5.0 (spack#8487) [mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST. (spack#8485) openssl: add new version 1.0.2o (spack#8486) Update the clang compiler definition to use IBM XL Fortran compiler (spack#8389) Patch trilinos for xlf when using clang (spack#8391) Use no mangling for all spack compiler definitions that use the XL (spack#8392) Use the name of the Fortran compiler to determine what name mangling (spack#8393) A new package: megahit. (spack#8471) neovim: add info for v0.3.0 (spack#8472) oce: add 0.18.3 (spack#8477) netgen should depend on zlib (spack#8473) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use no mangling for all spack compiler definitions that use the XL
Fortran compiler. Do this by checking the Fortran compiler itself as opposed to the compiler suite, as clang can build with IBM XL Fortran compiler as well (see #8311, #8388, #8389, #8391, #8393, #8394).