flux: changed default value for doc variant to False#7749
Merged
alalazo merged 1 commit intospack:developfrom Apr 13, 2018
Merged
flux: changed default value for doc variant to False#7749alalazo merged 1 commit intospack:developfrom
alalazo merged 1 commit intospack:developfrom
Conversation
davydden
approved these changes
Apr 13, 2018
Member
|
Does this bring in any extra dependencies? Increase the build time? I think the point of #2095 wasn't that documentation isn't useful, just that it isn't worth installing dependencies for. |
Member
Author
|
@adamjstewart I understood the issue more like asking for an informal convention, like we have for EDIT: |
Member
Author
|
Just checked, it brings in: depends_on("asciidoc", type='build', when="+docs")and this package brings in a few other dependencies: $ spack spec asciidoc
Input spec
--------------------------------
asciidoc
Concretized
--------------------------------
asciidoc@8.6.9%gcc@4.8 arch=linux-ubuntu14.04-x86_64
^docbook-xml@4.5%gcc@4.8 arch=linux-ubuntu14.04-x86_64
^docbook-xsl@1.79.1%gcc@4.8 arch=linux-ubuntu14.04-x86_64
^libxml2@2.9.4%gcc@4.8~python arch=linux-ubuntu14.04-x86_64
^pkgconf@1.4.0%gcc@4.8 arch=linux-ubuntu14.04-x86_64
^xz@5.2.3%gcc@4.8 arch=linux-ubuntu14.04-x86_64
^zlib@1.2.11%gcc@4.8+optimize+pic+shared arch=linux-ubuntu14.04-x86_64
^libxslt@1.1.29%gcc@4.8+crypto arch=linux-ubuntu14.04-x86_64
^libgcrypt@1.8.1%gcc@4.8 arch=linux-ubuntu14.04-x86_64
^libgpg-error@1.27%gcc@4.8 arch=linux-ubuntu14.04-x86_64
^libiconv@1.15%gcc@4.8 arch=linux-ubuntu14.04-x86_64 so proceeding with the merge. |
baberlevi
pushed a commit
to ResearchIT/spack
that referenced
this pull request
Apr 18, 2018
ch741
pushed a commit
to ch741/spack
that referenced
this pull request
Apr 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2095