Skip to content

Add suggestion to Contribution Guide to activate flake8#6886

Merged
adamjstewart merged 1 commit intospack:developfrom
adamjstewart:docs/activate-flake8
Jan 10, 2018
Merged

Add suggestion to Contribution Guide to activate flake8#6886
adamjstewart merged 1 commit intospack:developfrom
adamjstewart:docs/activate-flake8

Conversation

@adamjstewart
Copy link
Copy Markdown
Member

From #4155 (comment):

Should this advice to use spack activate py-flake8 be added to the "Flake8 warnings" in https://github.com/spack/spack/blob/develop/lib/spack/docs/contribution_guide.rst? I just ran into the bug in #4154 also, and eventually stumbled into this thread after trying to kludge around the problem.

Also updated the error message for Sphinx as I could no longer reproduce the bug when setuptools is not in the PYTHONPATH.

@goxberry

@adamjstewart adamjstewart added documentation Improvements or additions to documentation flake8 labels Jan 10, 2018
@adamjstewart adamjstewart merged commit 10ee7d6 into spack:develop Jan 10, 2018
@adamjstewart adamjstewart deleted the docs/activate-flake8 branch January 10, 2018 19:02
ch741 pushed a commit to ch741/spack that referenced this pull request Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation flake8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant