Skip to content

Fix parsing edge attributes#50714

Merged
alalazo merged 1 commit intospack:developfrom
alalazo:fixes/parser-edge-attributes
May 30, 2025
Merged

Fix parsing edge attributes#50714
alalazo merged 1 commit intospack:developfrom
alalazo:fixes/parser-edge-attributes

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented May 30, 2025

Before the PR:

$ spack -m spec mpileaks %[virtuals=c deptypes=build] gcc
==> Error: unexpected token in edge attributes
mpileaks %[virtuals=c deptypes='build]' gcc

After the PR:

$ spack -m spec mpileaks %[virtuals=c deptypes=build] gcc
 -   mpileaks@2.3~debug~opt+shared+static build_system=generic arch=linux-ubuntu20.04-icelake
...

Before the PR:
```console
$ spack -m spec mpileaks %[virtuals=c deptypes=build] gcc
==> Error: unexpected token in edge attributes
mpileaks %[virtuals=c deptypes='build]' gcc
```

After the PR:
```console
$ spack -m spec mpileaks %[virtuals=c deptypes=build] gcc
 -   mpileaks@2.3~debug~opt+shared+static build_system=generic arch=linux-ubuntu20.04-icelake
...
```

Signed-off-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
@spackbot-app spackbot-app bot added core PR affects Spack core functionality tests General test capability(ies) labels May 30, 2025
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented May 30, 2025

Force merging to speed-up rebasing #50481

@alalazo alalazo merged commit c0701d7 into spack:develop May 30, 2025
63 of 66 checks passed
@alalazo alalazo deleted the fixes/parser-edge-attributes branch May 30, 2025 11:11
kshea21 pushed a commit to kshea21/spack that referenced this pull request Jun 18, 2025
Before:
```console
$ spack -m spec mpileaks %[virtuals=c deptypes=build] gcc
==> Error: unexpected token in edge attributes
mpileaks %[virtuals=c deptypes='build]' gcc
```

After:
```console
$ spack -m spec mpileaks %[virtuals=c deptypes=build] gcc
 -   mpileaks@2.3~debug~opt+shared+static build_system=generic arch=linux-ubuntu20.04-icelake
...
```

Signed-off-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality tests General test capability(ies)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant