RepoSplit/tests: ensure test_import_package does not use 'builtin'#50584
Merged
haampie merged 7 commits intospack:developfrom Jun 2, 2025
Merged
RepoSplit/tests: ensure test_import_package does not use 'builtin'#50584haampie merged 7 commits intospack:developfrom
haampie merged 7 commits intospack:developfrom
Conversation
Member
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fix==> Running style checks on spack
selected: import, isort, black, flake8, mypy
==> Modified files
lib/spack/spack/cmd/edit.py
lib/spack/spack/test/packages.py
==> Running import checks
import checks were clean
==> Running isort checks
isort checks were clean
==> Running black checks
reformatted lib/spack/spack/cmd/edit.py
All done! ✨ 🍰 ✨
1 file reformatted, 1 file left unchanged.
black checks were clean
==> Running flake8 checks
flake8 checks were clean
==> Running mypy checks
Success: no issues found in 611 source files
mypy checks were clean
==> spack style checks were clean
I've updated the branch with style fixes. |
haampie
previously approved these changes
Jun 2, 2025
haampie
approved these changes
Jun 2, 2025
Closed
3 tasks
kshea21
pushed a commit
to kshea21/spack
that referenced
this pull request
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
test/packages.py::TestPackage::test_import_packageto ensure the unit test does not depend on thebuiltinbuild systems that are automatically added byspack.repo._PrependFileLoader(seespack/lib/spack/spack/repo.py
Line 88 in c86b286
By-passing the problem I reported earlier with
cmd/edit.pythat occurs when thebuiltinrepository is not available (see #50585), the unit test would otherwise fail as follows: