binary_distribution.py: stop relocation old /bin/bash sbang shebang#48502
Merged
binary_distribution.py: stop relocation old /bin/bash sbang shebang#48502
Conversation
3bb0f91 to
9e947e8
Compare
alalazo
reviewed
Jan 10, 2025
c7fe060 to
64ad26b
Compare
and simplify the prefix to prefix mapping and relocation code as a result
64ad26b to
2f1f936
Compare
alalazo
approved these changes
Jan 13, 2025
mtaillefumier
pushed a commit
to mtaillefumier/spack
that referenced
this pull request
Jan 20, 2025
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Feb 5, 2025
mrmundt
pushed a commit
to mrmundt/spack
that referenced
this pull request
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #48488.
This PR removes old relocation of
#!/bin/bash <path to spack>/bin/sbangshebang lines. Old sbang was basically not relocatable since it made packages have a dependency on Spack itself, not reflected in the DAG. This behavior was dropped 5 years ago in Spack v0.16, so it should be fine to drop by now.That allows a big cleanup of the relocation logic, where relocation simplifies to a single, ordered prefix to prefix mapping.