etsf-io: make object relocatable#45646
Merged
alalazo merged 1 commit intospack:developfrom Aug 12, 2024
Merged
Conversation
|
Hi @hmenke! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("hmenke")If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame etsf-ioThank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
alalazo
requested changes
Aug 12, 2024
alalazo
approved these changes
Aug 12, 2024
hmenke
added a commit
to hmenke/spack
that referenced
this pull request
Aug 13, 2024
(cherry picked from commit 6f61e38)
hmenke
added a commit
to hmenke/spack
that referenced
this pull request
Aug 13, 2024
(cherry picked from commit 6f61e38)
hmenke
added a commit
to hmenke/spack
that referenced
this pull request
Aug 13, 2024
(cherry picked from commit 6f61e38)
diehlpk
pushed a commit
to diehlpk/spack
that referenced
this pull request
Aug 14, 2024
Chrismarsh
pushed a commit
to Chrismarsh/spack
that referenced
this pull request
Aug 16, 2024
tldahlgren
pushed a commit
to AcriusWinter/spack
that referenced
this pull request
Aug 20, 2024
FrederickDeny
pushed a commit
to FrederickDeny/spack
that referenced
this pull request
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes errors like this:
The upstream package doesn't support building shared libraries and has been abandoned about 9 years ago, so it doesn't see likely that support will ever be added.
For comparison, Debian also simply adds
-fPICto make it possible to link etsf-io into a shared library: https://salsa.debian.org/science-team/etsf-io/-/blob/master/debian/rules?ref_type=heads#L9