Skip to content

py-glean-sdk: new package#45389

Merged
bernhardkaindl merged 2 commits intospack:developfrom
teaguesterling:packages/py-glean-sdk
Aug 2, 2024
Merged

py-glean-sdk: new package#45389
bernhardkaindl merged 2 commits intospack:developfrom
teaguesterling:packages/py-glean-sdk

Conversation

@teaguesterling
Copy link
Copy Markdown
Contributor

@teaguesterling teaguesterling commented Jul 23, 2024

Dependency of the Firefox PR.
Rebased on top of the merge of the dependency py-glean-parser into the develop branch.

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Jul 23, 2024

Hi @teaguesterling! I noticed that the following package(s) don't yet have maintainers:

  • py-glean-sdk

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("teaguesterling")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-glean-sdk

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

bernhardkaindl
bernhardkaindl previously approved these changes Aug 1, 2024
Copy link
Copy Markdown
Contributor

@bernhardkaindl bernhardkaindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Applied my additional commit for #45390
  • Update to current @60.4.0, use GitHub URL for spack checksum

Built successfully on Ubuntu 22.04.

Like for the other reviews with changes, I'll enable auto-merge with squash, and you can stop the merges by closing and reopening the PRs.

@bernhardkaindl bernhardkaindl enabled auto-merge (squash) August 1, 2024 00:11
teaguesterling and others added 2 commits August 2, 2024 13:02
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Bernhard Kaindl <bernhardkaindl7@gmail.com>
@bernhardkaindl
Copy link
Copy Markdown
Contributor

@teaguesterling

  1. Rebased on top of the merge of the dependency py-glean-parser into the develop branch.
  2. Updated to keep 60.0.1 in case Firefox needs this version specifically

@bernhardkaindl bernhardkaindl merged commit ff30da7 into spack:develop Aug 2, 2024
diehlpk pushed a commit to diehlpk/spack that referenced this pull request Aug 14, 2024
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Co-authored-by: Bernhard Kaindl <bernhardkaindl7@gmail.com>
Chrismarsh pushed a commit to Chrismarsh/spack that referenced this pull request Aug 16, 2024
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Co-authored-by: Bernhard Kaindl <bernhardkaindl7@gmail.com>
tldahlgren pushed a commit to AcriusWinter/spack that referenced this pull request Aug 20, 2024
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Co-authored-by: Bernhard Kaindl <bernhardkaindl7@gmail.com>
FrederickDeny pushed a commit to FrederickDeny/spack that referenced this pull request Aug 26, 2024
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Co-authored-by: Bernhard Kaindl <bernhardkaindl7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants