extensions: remove unused extendee_args() method#41942
Merged
Conversation
d36333f to
7381c57
Compare
alalazo
reviewed
Jan 4, 2024
|
|
||
| @directive(("extendees", "dependencies")) | ||
| def extends(spec, type=("build", "run"), **kwargs): | ||
| def extends(spec, when=None, type=("build", "run"), patches=None): |
Member
There was a problem hiding this comment.
This LGTM, modulo being sure you have seen #40326 (comment) If it's ok to break the API, considering that the breakage will probably affect a very small number of users, then this one is mergeable.
Member
Author
There was a problem hiding this comment.
I think the number is close to if not actually zero -- so I'm in inclined to assume that people have been using kwargs as I've never seen anyone not use kwargs for later arguments to directives.
alalazo
approved these changes
Jan 4, 2024
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 25, 2024
This method is vestigial; the only arg we ever used was `ignore=`, and that was eliminated in spack#29317 and spack#35588. The `kwargs` field of the extensions dictionary is actually completely unused now. Add a note for future removal.
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
This method is vestigial; the only arg we ever used was `ignore=`, and that was eliminated in spack#29317 and spack#35588. The `kwargs` field of the extensions dictionary is actually completely unused now. Add a note for future removal.
kwryankrattiger
pushed a commit
to kwryankrattiger/spack
that referenced
this pull request
Jul 9, 2024
This method is vestigial; the only arg we ever used was `ignore=`, and that was eliminated in spack#29317 and spack#35588. The `kwargs` field of the extensions dictionary is actually completely unused now. Add a note for future removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method is vestigial; the only arg we ever used was
ignore=, and that was eliminated in #29317 and #35588.The values of the
extendeesdictionary are completely unused now -- added a note for the next refactor.