mrtrix3: Fix some issues w/ 3.0.3 and add 3.0.4#41036
Conversation
|
Hi @moloney! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers("moloney")If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame mrtrix3Thank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
| depends_on("eigen@3.3", when="@3.0.3") | ||
| depends_on("eigen@3.4", when="@3.0.4:") |
There was a problem hiding this comment.
Is it necessary to pin the dependencies this specifically? Or can the ranges be broader?
There was a problem hiding this comment.
According to their docs they require eigen >= 3.2 with >= 3.3 recommended. These docs are actually slightly out-of-date as 3.0.4 does in fact require 3.4 to build.
There was a problem hiding this comment.
Greater or equal is expressed as:
| depends_on("eigen@3.3", when="@3.0.3") | |
| depends_on("eigen@3.4", when="@3.0.4:") | |
| depends_on("eigen@3.3:", when="@3.0.3") | |
| depends_on("eigen@3.4:", when="@3.0.4:") |
(note the additional :).
There was a problem hiding this comment.
Ah, sorry I forgot to mention that 3.0.3 won't compile with with eigen@3.4 due to conflicting declarations (which isn't mentioned in the docs).
There was a problem hiding this comment.
In that case, can you add a comment about that and use a range for the other directive
| depends_on("eigen@3.3", when="@3.0.3") | |
| depends_on("eigen@3.4", when="@3.0.4:") | |
| # <Brief comment explaining why only 3.3> | |
| depends_on("eigen@3.3", when="@3.0.3") | |
| depends_on("eigen@3.4:", when="@3.0.4:") |
?
There was a problem hiding this comment.
Ok, should be resolved with latest commit. I also put a version upper bound on the patch since it sounds like it should be fixed upstream shortly.
Fixes issues with the 'configure' script replacing "-I " args with "-idirafter ". Set needed "eigen" version based on mrtrix3 version. Add 3.0.4 version.