llvm: remove build type comment#39087
Merged
haampie merged 1 commit intospack:developfrom Jul 26, 2023
Merged
Conversation
The message is now outdated after spack#36679 which could lead to some confusion.
haampie
approved these changes
Jul 26, 2023
mpokorny
pushed a commit
to mpokorny/spack
that referenced
this pull request
Sep 18, 2023
The message is now outdated after spack#36679 which could lead to some confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message is now outdated after
#36679 which could lead to some confusion.
I've removed the entire message here as after the change listed above I don't think it is really relevant, but if other reviewers are interested in keeping a partial message and only eliminating the last sentence, that would probably be a good option as well.