Fix namespaced python packages#3757
Merged
adamjstewart merged 4 commits intospack:developfrom Apr 10, 2017
Merged
Conversation
Member
|
Can you also check |
adamjstewart
reviewed
Apr 7, 2017
| version('1.0.0', '03267762480bd86b50580dc19dff3c66') | ||
|
|
||
| depends_on('py-setuptools', type='build') | ||
| # newer setuptools version mess with "namespace" packages in a incompatible |
Contributor
Author
I couldn't reproduce the problem with either of those, but I also not 100% sure how this would manifest (and right now, I don't have the time to spare) |
adamjstewart
approved these changes
Apr 10, 2017
diaena
pushed a commit
to diaena/spack
that referenced
this pull request
May 26, 2017
* Fix namespaced python packages * Update package.py * Update package.py * fix typo
xavierandrade
pushed a commit
to xavierandrade/spack
that referenced
this pull request
Jun 16, 2017
* Fix namespaced python packages * Update package.py * Update package.py * fix typo
EmreAtes
pushed a commit
to EmreAtes/spack
that referenced
this pull request
Jul 10, 2017
* Fix namespaced python packages * Update package.py * Update package.py * fix typo
amklinv
pushed a commit
that referenced
this pull request
Jul 17, 2017
* Fix namespaced python packages * Update package.py * Update package.py * fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those two are probably not the only ones...