Add test for conditions triggered by package requirements#36589
Open
scheibelp wants to merge 3 commits intospack:developfrom
Open
Add test for conditions triggered by package requirements#36589scheibelp wants to merge 3 commits intospack:developfrom
scheibelp wants to merge 3 commits intospack:developfrom
Conversation
2 tasks
scheibelp
added a commit
to scheibelp/spack
that referenced
this pull request
Apr 5, 2023
…ts (the same is not needed for preferences because the other work in this commit forbids preferences from defining versions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue with preferences (see: #36574) was observed where new versions added by preferences failed to trigger conditions in the package. I created a test expecting a similar failure for package requirements but it succeeds, so these must be handled differently.
Note this does not fix the referenced PR, it only confirms that a similar issue does not exist for package requirements.