Skip to content

ci: Increase the amount of pruning possible for PR pipelines#35944

Merged
tgamblin merged 1 commit intospack:developfrom
scottwittenburg:gitlab-prs-traverse-depth-1
Mar 10, 2023
Merged

ci: Increase the amount of pruning possible for PR pipelines#35944
tgamblin merged 1 commit intospack:developfrom
scottwittenburg:gitlab-prs-traverse-depth-1

Conversation

@scottwittenburg
Copy link
Copy Markdown
Contributor

Now that we have a knob for controlling the amount of traversal done in the case of "untouched spec pruning" (#35274), use it to increase the amount of pruning possible for PR pipelines. By setting the traversal depth to 1, only specs matching changed packages and direct dependents of those (and of course all dependencies of that set) are removed from pruning candidacy.

By setting the traversal depth to 1, only specs matching the changed
package and direct dependents of those (and of course all dependencies
of that set) are removed from pruning candidacy.
@spackbot-app spackbot-app bot added core PR affects Spack core functionality gitlab Issues related to gitlab integration labels Mar 8, 2023
@tgamblin tgamblin enabled auto-merge (squash) March 8, 2023 17:36
@tgamblin tgamblin disabled auto-merge March 10, 2023 19:19
@tgamblin tgamblin merged commit 16c67ff into spack:develop Mar 10, 2023
@haampie
Copy link
Copy Markdown
Member

haampie commented Mar 14, 2023

It would help if there right variable was specified here

alalazo pushed a commit that referenced this pull request Mar 14, 2023
@scottwittenburg scottwittenburg deleted the gitlab-prs-traverse-depth-1 branch March 14, 2023 15:21
@scottwittenburg
Copy link
Copy Markdown
Contributor Author

Thanks @haampie I wonder if I wouldn't have goofed that up if I had chosen a better name for the variable.

cnegre pushed a commit to cnegre/spack that referenced this pull request Mar 20, 2023
jmcarcell pushed a commit to key4hep/spack that referenced this pull request Apr 13, 2023
…5944)

By setting the traversal depth to 1, only specs matching the changed
package and direct dependents of those (and of course all dependencies
of that set) are removed from pruning candidacy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality gitlab Issues related to gitlab integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants