Skip to content

Fix for find --explicit #3374#3492

Merged
tgamblin merged 1 commit intodevelopfrom
bugfix/find-implicit-explicit
Mar 21, 2017
Merged

Fix for find --explicit #3374#3492
tgamblin merged 1 commit intodevelopfrom
bugfix/find-implicit-explicit

Conversation

@hartzell
Copy link
Copy Markdown
Contributor

@hartzell hartzell commented Mar 19, 2017

This fixes the problem described in #3374, which describes spack find ignoring the explicit/implicit flags.

I believe that this was broken in #2626.

This restores the behavior of implicit/explicit for me.

I believe that it does not screw anything else up, but ....

This fixes the problem described in #3374, which describes `spack find` ignore explicit/implicit.

I believe that this was broken in #2626.

This restores the behavior of implicit/explicit for me.

I believe that it does not screw anything else up, but ....
@hartzell hartzell requested a review from tgamblin March 19, 2017 19:00
@hartzell
Copy link
Copy Markdown
Contributor Author

@healther -- Does this fix your problem with implicit/explicit?

@healther
Copy link
Copy Markdown
Contributor

@hartzell yes this removes (at least on my local installation) the automatically installed packages. I wanted to take a shot at this myself, but I ran into an issue regarding the dependencies of py-pudb and hadn't had the time to investigate this properly... See #3501

You can close #3374 from my side.

@tgamblin tgamblin merged commit 9b5f5fc into develop Mar 21, 2017
@tgamblin
Copy link
Copy Markdown
Member

@hartzell: thanks!

@tgamblin tgamblin deleted the bugfix/find-implicit-explicit branch March 21, 2017 23:31
diaena pushed a commit to diaena/spack that referenced this pull request May 26, 2017
This fixes the problem described in spack#3374, which describes `spack find` ignore explicit/implicit.

I believe that this was broken in spack#2626.

This restores the behavior of implicit/explicit for me.

I believe that it does not screw anything else up, but ....
xavierandrade pushed a commit to xavierandrade/spack that referenced this pull request Jun 16, 2017
This fixes the problem described in spack#3374, which describes `spack find` ignore explicit/implicit.

I believe that this was broken in spack#2626.

This restores the behavior of implicit/explicit for me.

I believe that it does not screw anything else up, but ....
EmreAtes pushed a commit to EmreAtes/spack that referenced this pull request Jul 10, 2017
This fixes the problem described in spack#3374, which describes `spack find` ignore explicit/implicit.

I believe that this was broken in spack#2626.

This restores the behavior of implicit/explicit for me.

I believe that it does not screw anything else up, but ....
amklinv pushed a commit that referenced this pull request Jul 17, 2017
This fixes the problem described in #3374, which describes `spack find` ignore explicit/implicit.

I believe that this was broken in #2626.

This restores the behavior of implicit/explicit for me.

I believe that it does not screw anything else up, but ....
healther pushed a commit to electronicvisions/spack that referenced this pull request Jul 26, 2017
This fixes the problem described in spack#3374, which describes `spack find` ignore explicit/implicit.

I believe that this was broken in spack#2626.

This restores the behavior of implicit/explicit for me.

I believe that it does not screw anything else up, but ....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants