Skip to content

spack.dependency: add type hints#34807

Merged
alalazo merged 1 commit intospack:developfrom
alalazo:maintainers/type_check_dependency
Jan 5, 2023
Merged

spack.dependency: add type hints#34807
alalazo merged 1 commit intospack:developfrom
alalazo:maintainers/type_check_dependency

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Jan 4, 2023

Extracted from a larger branch that modifies edges in DAGs to keep track of virtual dependencies. This helps avoiding type-matching issues while we refactor the code.

Modifications:

  • Add type hints to code in spack.dependency

@spackbot-app spackbot-app bot added the core PR affects Spack core functionality label Jan 4, 2023
def __init__(self, pkg, spec, type=default_deptype):
def __init__(
self,
pkg: "spack.package_base.PackageBase",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh, python 😆

@alalazo alalazo merged commit eace2eb into spack:develop Jan 5, 2023
@alalazo alalazo deleted the maintainers/type_check_dependency branch January 5, 2023 16:48
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Jan 24, 2023
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
techxdave pushed a commit to Tech-XCorp/spack that referenced this pull request Feb 17, 2023
jmcarcell pushed a commit to key4hep/spack that referenced this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants