py-tensorboard-data-server: add Linux aarch64 support#34437
Merged
alalazo merged 1 commit intospack:developfrom Dec 12, 2022
Merged
py-tensorboard-data-server: add Linux aarch64 support#34437alalazo merged 1 commit intospack:developfrom
alalazo merged 1 commit intospack:developfrom
Conversation
Contributor
bernhardkaindl
left a comment
There was a problem hiding this comment.
Confirming build on aarch64-linux with external rust (building rust from source takes a long time)
Notice: With external rust, when rustfmt is not installed, build fails with:
==> Error: ProcessError: Command exited with status 101:
'/usr/bin/cargo' 'build' '--release'
1 error found in build log:
304 Compiling tower v0.4.6
305 Compiling hyper v0.14.2
306 Compiling tonic-build v0.4.2
307 Compiling tonic-reflection v0.1.0
308 Compiling hyper-rustls v0.22.1
309 Compiling tonic v0.4.2
>> 310 error: failed to run custom build command for `tonic-reflection v0.1.0`
311
312 Caused by:
313 process didn't exit successfully: `spack-stage-py-tensorboard-data-server-0.6.1-jjhgcll5nroku5pzrcfbwsnvlhrsyy3y/spack-src/tensorboard
/data/server/target/release/build/tonic-reflection-f629cb57ce97759a/build-script-build` (exit status: 1)
314 --- stderr
315 error running rustfmt: Os { code: 2, kind: NotFound, message: "No such file or directory" }spacks build of internal rustrecipe always buildscargobut inspack external find rust, it doesn't not check for cargo, so I initially guessed it might be similar for rustfmt, but +rustfmtis a variant of therust` recipe.
Thus AFAICS, py-tensorboard-data-server needs +rustfmt added to it's depends_on.
As this is a different issue, I don't want to delay merging this.
bernhardkaindl
approved these changes
Dec 12, 2022
alalazo
approved these changes
Dec 12, 2022
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See tensorflow/tensorboard#6101 for details.
Discovered in #34300