Skip to content

valgrind: add v3.20.0, mark macOS conflict#34436

Merged
michaelkuhn merged 1 commit intospack:developfrom
adamjstewart:packages/valgrind
Dec 10, 2022
Merged

valgrind: add v3.20.0, mark macOS conflict#34436
michaelkuhn merged 1 commit intospack:developfrom
adamjstewart:packages/valgrind

Conversation

@adamjstewart
Copy link
Copy Markdown
Member

Was quite surprised to find that valgrind simply does not support macOS anymore. Couldn't test the new version, hopefully it works.

@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Dec 10, 2022

Hi @adamjstewart! I noticed that the following package(s) don't yet have maintainers:

  • valgrind

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ["adamjstewart"]

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame valgrind

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

Copy link
Copy Markdown
Member

@michaelkuhn michaelkuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me (tested with ~mpi)

@michaelkuhn michaelkuhn self-assigned this Dec 10, 2022
@michaelkuhn michaelkuhn merged commit 46010ef into spack:develop Dec 10, 2022
@adamjstewart adamjstewart deleted the packages/valgrind branch December 10, 2022 15:07
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants