rocm: add all GFX9, GFX10 and GFX11 amdgpu_targets#33871
Merged
tldahlgren merged 1 commit intospack:developfrom Nov 14, 2022
Merged
rocm: add all GFX9, GFX10 and GFX11 amdgpu_targets#33871tldahlgren merged 1 commit intospack:developfrom
tldahlgren merged 1 commit intospack:developfrom
Conversation
This change adds all documented AMDGPU processors from GFX9 through GFX11 and sorts the list.
9ffed57 to
b74ab85
Compare
srekolam
approved these changes
Nov 14, 2022
Contributor
|
Thanks for keeping things up to date! I appreciate it |
charmoniumQ
pushed a commit
to charmoniumQ/spack
that referenced
this pull request
Nov 19, 2022
This change adds all documented AMDGPU processors from GFX9 through GFX11 and sorts the list.
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
This change adds all documented AMDGPU processors from GFX9 through GFX11 and sorts the list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds all documented AMDGPU processors from GFX9 through GFX11 and sorts the list.
There have been proposals such as #29018 which have been more ambitious about improving the
amdgpu_targets. I'm cheering that effort on, but for the moment maybe we can just extend the list with the newly added values.