Skip to content

remove deprecated top-level module config#33828

Merged
tgamblin merged 3 commits intodevelopfrom
deprecations/module-top-level-config
Nov 11, 2022
Merged

remove deprecated top-level module config#33828
tgamblin merged 3 commits intodevelopfrom
deprecations/module-top-level-config

Conversation

@becker33
Copy link
Copy Markdown
Member

@becker33 becker33 commented Nov 10, 2022

Deprecated in v0.18.0, scheduled for removal in v0.19.0

@spackbot-app spackbot-app bot added core PR affects Spack core functionality modules labels Nov 10, 2022
haampie
haampie previously approved these changes Nov 11, 2022
@haampie
Copy link
Copy Markdown
Member

haampie commented Nov 11, 2022

Also should drop deprecation_msg_default_module_set. Top-level prefix_inspections are still a thing

@tgamblin tgamblin enabled auto-merge (squash) November 11, 2022 07:35
@tgamblin tgamblin disabled auto-merge November 11, 2022 07:35
@tgamblin tgamblin merged commit f11778b into develop Nov 11, 2022
@tgamblin tgamblin deleted the deprecations/module-top-level-config branch November 11, 2022 07:35
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Nov 11, 2022
* remove deprecated top-level module config per deprecation in 0.18
charmoniumQ pushed a commit to charmoniumQ/spack that referenced this pull request Nov 19, 2022
* remove deprecated top-level module config per deprecation in 0.18
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
* remove deprecated top-level module config per deprecation in 0.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core PR affects Spack core functionality modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants