Fixes the Elemental and LBANN packages to conform to the new syntax#3382
Merged
adamjstewart merged 1 commit intospack:developfrom Mar 8, 2017
Merged
Fixes the Elemental and LBANN packages to conform to the new syntax#3382adamjstewart merged 1 commit intospack:developfrom
adamjstewart merged 1 commit intospack:developfrom
Conversation
adamjstewart
reviewed
Mar 8, 2017
| depends_on('cuda', when='+gpu') | ||
| depends_on('mpi') | ||
| depends_on('opencv@2.4.13', when='+opencv') | ||
| depends_on('opencv@3.2.0', when='+opencv') |
Member
There was a problem hiding this comment.
Just to confirm, is this change intended to be in this PR? It wasn't mentioned in the description so I wanted to make sure it didn't slip in accidentally.
Contributor
Author
|
Yes, I also updated that.
Brian C. Van Essen
vanessen1@llnl.gov
(w) 925-422-9300
(c) 925-290-5470
… On Mar 8, 2017, at 9:33 AM, Adam J. Stewart ***@***.***> wrote:
@adamjstewart commented on this pull request.
In var/spack/repos/builtin/packages/lbann/package.py:
> @@ -45,7 +45,7 @@ class Lbann(CMakePackage):
depends_on('elemental +openmp_blas +scalapack +shared +int64 +debug', when='+debug')
depends_on('cuda', when='+gpu')
depends_on('mpi')
- ***@***.***', when='+opencv')
+ ***@***.***', when='+opencv')
Just to confirm, is this change intended to be in this PR? It wasn't mentioned in the description so I wanted to make sure it didn't slip in accidentally.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
adamjstewart
approved these changes
Mar 8, 2017
davydden
approved these changes
Mar 8, 2017
diaena
pushed a commit
to diaena/spack
that referenced
this pull request
May 26, 2017
xavierandrade
pushed a commit
to xavierandrade/spack
that referenced
this pull request
Jun 16, 2017
EmreAtes
pushed a commit
to EmreAtes/spack
that referenced
this pull request
Jul 10, 2017
amklinv
pushed a commit
that referenced
this pull request
Jul 17, 2017
healther
pushed a commit
to electronicvisions/spack
that referenced
this pull request
Jul 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduced by PR #1875