add elf parsing utility function#33628
Merged
haampie merged 1 commit intospack:developfrom Nov 1, 2022
Merged
Conversation
b923698 to
d5ab98c
Compare
bbe79b7 to
7118cc6
Compare
This was referenced Oct 31, 2022
trws
reviewed
Nov 1, 2022
trws
reviewed
Nov 1, 2022
trws
reviewed
Nov 1, 2022
trws
reviewed
Nov 1, 2022
Contributor
|
I like this, a lot, and the test changes are really welcome. Had a couple of questions but I don't see anything that would make me want to keep this out. |
3fed26b to
4b9d459
Compare
trws
approved these changes
Nov 1, 2022
charmoniumQ
pushed a commit
to charmoniumQ/spack
that referenced
this pull request
Nov 19, 2022
Introduces `spack.util.elf.parse_elf(file_handle)`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces some basic ELF parsing logic, which is useful in various
places.
Example uses:
malformed elf, no dynamic section, missing tag in dynamic array, ...), this
is more fine-grained than in patchelf.
It's very basic, and it's really about parsing, since we don't want to reimplement
the advanced dynamic section growth logic that patchelf offers.
Current API is basically:
Another advantage is that we get a ~850x speedup for retrieving rpaths.