Skip to content

Remove support for running with Python 2.7#33063

Merged
alalazo merged 4 commits intospack:developfrom
alalazo:maintainers/remove_python_27_specific_code
Nov 14, 2022
Merged

Remove support for running with Python 2.7#33063
alalazo merged 4 commits intospack:developfrom
alalazo:maintainers/remove_python_27_specific_code

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Oct 6, 2022 •
edited
Loading

This PR removes support for running Spack with Python 2.7. Should be merged after the v0.19 release.

Modifications:

  • Remove all the tests in CI using or referring to Python 2.7
  • Remove all the branches in the code specific to Python 2.7
  • Remove vendored dependencies used only with Python 2.7

@alalazo alalazo mentioned this pull request Oct 6, 2022
Merged
@alalazo alalazo force-pushed the maintainers/remove_python_27_specific_code branch from dd93fff to 89b7075 Compare October 14, 2022 07:23
@alalazo alalazo force-pushed the maintainers/remove_python_27_specific_code branch 2 times, most recently from 3ab76c8 to 266a6b8 Compare October 14, 2022 08:34
@alalazo alalazo changed the title Remove Python 2.7 specific code Remove support for running with Python 2.7 Oct 14, 2022
@alalazo alalazo force-pushed the maintainers/remove_python_27_specific_code branch from 266a6b8 to de13df8 Compare October 19, 2022 09:20
@alalazo alalazo mentioned this pull request Oct 22, 2022
Merged
@alalazo alalazo force-pushed the maintainers/remove_python_27_specific_code branch from de13df8 to 4931ec0 Compare October 26, 2022 19:46
@alalazo alalazo force-pushed the maintainers/remove_python_27_specific_code branch from 4931ec0 to f0f1fae Compare November 7, 2022 12:55
@spackbot-app spackbot-app bot added build-systems directives documentation Improvements or additions to documentation labels Nov 7, 2022
@alalazo alalazo force-pushed the maintainers/remove_python_27_specific_code branch from f0f1fae to 1bfb527 Compare November 11, 2022 07:47
@alalazo alalazo marked this pull request as ready for review November 12, 2022 07:46
@alalazo alalazo force-pushed the maintainers/remove_python_27_specific_code branch from 1bfb527 to 21bb391 Compare November 12, 2022 07:47
@alalazo alalazo mentioned this pull request Nov 12, 2022
Merged
4 tasks
@alalazo alalazo force-pushed the maintainers/remove_python_27_specific_code branch from 21bb391 to b392e9d Compare November 14, 2022 08:07
tgamblin
tgamblin approved these changes Nov 14, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@tgamblin tgamblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alalazo alalazo merged commit 3efa4ee into spack:develop Nov 14, 2022
@alalazo alalazo deleted the maintainers/remove_python_27_specific_code branch November 14, 2022 12:11
@adamjstewart
Copy link
Copy Markdown
Member

adamjstewart commented Nov 15, 2022

This is now outdated: https://spack.readthedocs.io/en/latest/getting_started.html#system-prerequisites

@adamjstewart adamjstewart mentioned this pull request Nov 15, 2022
Merged
charmoniumQ pushed a commit to charmoniumQ/spack that referenced this pull request Nov 19, 2022
@alalazo @charmoniumQ
Remove support for running with Python 2.7 (spack#33063)
f467932 
* Remove CI jobs related to Python 2.7

* Remove Python 2.7 specific code from Spack core

* Remove externals for Python 2 only

* Remove llnl.util.compat
@greenc-FNAL greenc-FNAL mentioned this pull request Nov 21, 2022
Closed
@greenc-FNAL greenc-FNAL mentioned this pull request Dec 1, 2022
Closed
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
@alalazo
Remove support for running with Python 2.7 (spack#33063)
1a57d9f 
* Remove CI jobs related to Python 2.7

* Remove Python 2.7 specific code from Spack core

* Remove externals for Python 2 only

* Remove llnl.util.compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgamblin tgamblin tgamblin approved these changes

Assignees

No one assigned

Labels

architecture build-environment build-systems commands compilers core PR affects Spack core functionality directives documentation Improvements or additions to documentation fetching tests General test capability(ies) update-package utilities vendored-dependencies workflow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alalazo @adamjstewart @tgamblin