Skip to content

new packages: py-arm-pyart and dependencies#32579

Merged
adamjstewart merged 6 commits intospack:developfrom
glennpj:new/py-arm-pyart
Sep 10, 2022
Merged

new packages: py-arm-pyart and dependencies#32579
adamjstewart merged 6 commits intospack:developfrom
glennpj:new/py-arm-pyart

Conversation

@glennpj
Copy link
Copy Markdown
Contributor

@glennpj glennpj commented Sep 8, 2022

  • py-arm-pyart
  • py-cylp
  • rsl

- py-arm-pyart
- py-cylp
- rsl
@spackbot-app
Copy link
Copy Markdown

spackbot-app bot commented Sep 8, 2022

Hi @glennpj! I noticed that the following package(s) don't yet have maintainers:

  • py-arm-pyart
  • py-cylp
  • rsl

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['glennpj']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-arm-pyart

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@adamjstewart adamjstewart self-assigned this Sep 9, 2022
glennpj and others added 2 commits September 8, 2022 22:22
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
- xarray is not optional
- pandas is needed
- pylab is needed
  - new package, py-pylab-sdk
- setuptools is needed at run time
@spackbot-app spackbot-app bot added the patch label Sep 10, 2022
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
@adamjstewart adamjstewart enabled auto-merge (squash) September 10, 2022 23:01
@adamjstewart adamjstewart merged commit 01153b3 into spack:develop Sep 10, 2022
@glennpj glennpj deleted the new/py-arm-pyart branch September 11, 2022 01:32
@alalazo
Copy link
Copy Markdown
Member

alalazo commented Sep 12, 2022

This PR introduced somehow a failure in the bootstrap tests. I'll investigate that, but we should probably require bootstrap to pass now that we have a unique workflow.

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Sep 12, 2022

Another seemingly related failure: https://github.com/spack/spack/runs/8294123611?check_suite_focus=true

ma595 pushed a commit to ma595/spack that referenced this pull request Sep 13, 2022
* new packages: py-arm-pyart and dependencies

- py-arm-pyart
- py-cylp
- rsl

* Update var/spack/repos/builtin/packages/py-cylp/package.py

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Fix dependencies

- xarray is not optional
- pandas is needed
- pylab is needed
  - new package, py-pylab-sdk
- setuptools is needed at run time

* Patch for import of StringIO

* Update var/spack/repos/builtin/packages/py-arm-pyart/package.py

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>

* Fix call to `StringIO` in patch

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants