Skip to content

e4s ci: add raja +rocm#32505

Merged
eugeneswalker merged 2 commits intospack:developfrom
eugeneswalker:e4s-add-raja-rocm
Oct 20, 2022
Merged

e4s ci: add raja +rocm#32505
eugeneswalker merged 2 commits intospack:developfrom
eugeneswalker:e4s-add-raja-rocm

Conversation

@eugeneswalker
Copy link
Copy Markdown
Contributor

@eugeneswalker eugeneswalker commented Sep 3, 2022

Hoping the merge of #32469 has fixed issue with raja +rocm in our CI environment.

FYI @wspear @davidbeckingsale

@eugeneswalker eugeneswalker added e4s ROCm/hip Support for ROCm/hip labels Sep 3, 2022
@spackbot-app spackbot-app bot added core PR affects Spack core functionality gitlab Issues related to gitlab integration labels Sep 3, 2022
@alalazo alalazo self-assigned this Sep 12, 2022
alalazo
alalazo requested changes Sep 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raja is failing to build https://gitlab.spack.io/spack/spack/-/jobs/3188510

@eugeneswalker
Copy link
Copy Markdown
Contributor Author

eugeneswalker commented Sep 12, 2022

raja is failing to build https://gitlab.spack.io/spack/spack/-/jobs/3188510

Issue is that camp.hip_repair_option method is not safe for CachedCMakePackage:

Will submit PR and once merged, rebase this on develop.

@eugeneswalker
Copy link
Copy Markdown
Contributor Author

eugeneswalker commented Sep 12, 2022 •
edited
Loading

Replacing camp.hip_repair_option in raja's package.py:

with:

import glob
entries.append(cmake_cache_path("HIP_CLANG_INCLUDE_PATH", glob.glob("{}/lib/clang/*/include".format(spec["llvm-amdgpu"].prefix))[0]))

... gets me past the CMake issue.

But then there is this:

==> Installing raja-2022.03.0-qaar7rx6sm3ynowczhnpq7ocisbk46ah
==> No binary for raja-2022.03.0-qaar7rx6sm3ynowczhnpq7ocisbk46ah found: installing from source
==> Using cached archive: /spack/var/spack/cache/_source-cache/git//LLNL/RAJA.git/v2022.03.0.tar.gz
==> Warning: Fetching from mirror without a checksum!
  This package is normally checked out from a version control system, but it has been archived on a spack mirror.  This means we cannot know a checksum for the tarball in advance. Be sure that your connection to this mirror is secure!
==> No patches needed for raja
==> raja: Executing phase: 'initconfig'
==> raja: Executing phase: 'cmake'
==> raja: Executing phase: 'build'
==> Error: ProcessError: Command exited with status 2:
    'make' '-j32'
...
  >> 124    g++: error: unrecognized command-line option '--rocm-path=/spack/opt/spack/linux-ubuntu22.04-x86_64/gcc-11.2.0/hip-5.2.0-bv7urfoqfdriepvm6ytgd3wubhv4smbv'
  >> 125    g++: error: unrecognized command-line option '--rocm-path=/spack/opt/spack/linux-ubuntu22.04-x86_64/gcc-11.2.0/hip-5.2.0-bv7urfoqfdriepvm6ytgd3wubhv4smbv'
  >> 126    g++: error: unrecognized command-line option '--rocm-path=/spack/opt/spack/linux-ubuntu22.04-x86_64/gcc-11.2.0/hip-5.2.0-bv7urfoqfdriepvm6ytgd3wubhv4smbv'
  >> 127    g++: error: unrecognized command-line option '--rocm-path=/spack/opt/spack/linux-ubuntu22.04-x86_64/gcc-11.2.0/hip-5.2.0-bv7urfoqfdriepvm6ytgd3wubhv4smbv'
  >> 128    g++: error: unrecognized command-line option '--rocm-path=/spack/opt/spack/linux-ubuntu22.04-x86_64/gcc-11.2.0/hip-5.2.0-bv7urfoqfdriepvm6ytgd3wubhv4smbv'
  >> 129    g++: error: unrecognized command-line option '--rocm-path=/spack/opt/spack/linux-ubuntu22.04-x86_64/gcc-11.2.0/hip-5.2.0-bv7urfoqfdriepvm6ytgd3wubhv4smbv'
  >> 130    g++: error: unrecognized command-line option '--rocm-path=/spack/opt/spack/linux-ubuntu22.04-x86_64/gcc-11.2.0/hip-5.2.0-bv7urfoqfdriepvm6ytgd3wubhv4smbv'
  >> 131    g++: error: unrecognized command-line option '--offload-arch=gfx900'
  >> 132    make[2]: *** [CMakeFiles/RAJA.dir/build.make:79: CMakeFiles/RAJA.dir/src/AlignedRangeIndexSetBuilders.cpp.o] Error 1
     133    make[2]: *** Waiting for unfinished jobs....
  >> 134    g++: error: unrecognized command-line option '--offload-arch=gfx900'
  >> 135    make[2]: *** [CMakeFiles/RAJA.dir/build.make:121: CMakeFiles/RAJA.dir/src/MemUtils_CUDA.cpp.o] Error 1
  >> 136    g++: error: unrecognized command-line option '--offload-arch=gfx900'
  >> 137    make[2]: *** [CMakeFiles/RAJA.dir/build.make:149: CMakeFiles/RAJA.dir/src/MemUtils_SYCL.cpp.o] Error 1
  >> 138    g++: error: unrecognized command-line option '--offload-arch=gfx900'
  >> 139    make[2]: *** [CMakeFiles/RAJA.dir/build.make:93: CMakeFiles/RAJA.dir/src/DepGraphNode.cpp.o] Error 1
  >> 140    g++: error: unrecognized command-line option '--offload-arch=gfx900'
  >> 141    g++: error: unrecognized command-line option '--offload-arch=gfx900'
  >> 142    make[2]: *** [CMakeFiles/RAJA.dir/build.make:107: CMakeFiles/RAJA.dir/src/LockFreeIndexSetBuilders.cpp.o] Error 1
  >> 143    make[2]: *** [CMakeFiles/RAJA.dir/build.make:163: CMakeFiles/RAJA.dir/src/PluginStrategy.cpp.o] Error 1
  >> 144    g++: error: unrecognized command-line option '--offload-arch=gfx900'
  >> 145    make[2]: *** [CMakeFiles/RAJA.dir/build.make:135: CMakeFiles/RAJA.dir/src/MemUtils_HIP.cpp.o] Error 1
     146    make[2]: Leaving directory '/tmp/root/spack-stage/spack-stage-raja-2022.03.0-qaar7rx6sm3ynowczhnpq7ocisbk46ah/spack-build-qaar7rx'
  >> 147    make[1]: *** [CMakeFiles/Makefile2:273: CMakeFiles/RAJA.dir/all] Error 2
     148    make[1]: Leaving directory '/tmp/root/spack-stage/spack-stage-raja-2022.03.0-qaar7rx6sm3ynowczhnpq7ocisbk46ah/spack-build-qaar7rx'
  >> 149    make: *** [Makefile:139: all] Error 2

@balos1 balos1 mentioned this pull request Sep 16, 2022
Merged
@eugeneswalker eugeneswalker mentioned this pull request Sep 26, 2022
Closed
4 tasks
@eugeneswalker eugeneswalker force-pushed the e4s-add-raja-rocm branch 2 times, most recently from 3f680cc to b761d72 Compare October 10, 2022 19:46
@eugeneswalker
Copy link
Copy Markdown
Contributor Author

eugeneswalker commented Oct 12, 2022

This PR can move forward once #33249 is resolved.

@eugeneswalker eugeneswalker enabled auto-merge (squash) October 19, 2022 21:48
@eugeneswalker eugeneswalker requested a review from wspear October 19, 2022 21:48
wspear
wspear previously approved these changes Oct 19, 2022
View reviewed changes
@eugeneswalker eugeneswalker requested review from alalazo and removed request for alalazo October 19, 2022 22:22
alalazo
alalazo previously approved these changes Oct 20, 2022
View reviewed changes
@eugeneswalker eugeneswalker dismissed stale reviews from alalazo and wspear via d4ddcf1 October 20, 2022 15:09
@eugeneswalker eugeneswalker requested a review from wspear October 20, 2022 15:56
@eugeneswalker eugeneswalker merged commit 1e4732d into spack:develop Oct 20, 2022
eugeneswalker added a commit to eugeneswalker/spack that referenced this pull request Oct 21, 2022
@eugeneswalker
e4s ci: add raja +rocm (spack#32505)
6f3879b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalazo alalazo alalazo left review comments

+1 more reviewer

@wspear wspear wspear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alalazo alalazo

Labels

core PR affects Spack core functionality e4s gitlab Issues related to gitlab integration ROCm/hip Support for ROCm/hip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eugeneswalker @alalazo @wspear